fix: Only take a new attempt on beginAttempt for items which endAttempt was invoked to allow skipped items to be navigated freely
#298
+73
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tempt` was invoked to allow skipped items to be navigated freely
quintanilhar
requested review from
julien-sebire,
wazelin,
yukipastelcat,
augustas,
Businesspunk,
emgolubev,
boajer and
poyuki
and removed request for
yukipastelcat
julien-sebire
approved these changes
Oct 20, 2021
poyuki
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
quintanilhar
deleted the
fix/TR-1241/attempt-taken-for-non-attempted-items
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://oat-sa.atlassian.net/browse/TR-1241
Summary
A test taker can decide to skip an item for non-linear tests with items configured with multiple attempts, however, it should not take an attempt away, it should rather put the item in
suspendmode and resume the attempt once the item is displayed again. This is done currently by the actionendCandidateSession. This is a valid operation but it's currently calling theendAttemptmethod underneath.This PR introduces 2 changes to avoid taking attempts away incorrectly:
1- Remove the
endAttemptcall from theendCandidationSessionmethod;2- Add a new condition before considering a new attempt to check if the attempt was really ended by the test taker (with
endAttemptcall);Dependencies
No dependencies